feat(I3C): adding support for I3C#5
Conversation
Signed-off-by: Aymane Bahssain <aymane.bahssain@st.com>
fpistm
left a comment
fpistm
left a comment
There was a problem hiding this comment.
I recommend to add a check for the core version.
#if defined(STM32_CORE_VERSION) && (STM32_CORE_VERSION <= 0x020C0000)
#error "This library is not compatible with core version used. Please update the core."
#endif
cparata
left a comment
cparata
left a comment
There was a problem hiding this comment.
Looks Good To Me, but I would wait for an official release of the STM32duino Core that integrates the I3C support before integrating this PR. The only thing is about the file CMakeLists.txt: is it mandatory?
Hello Carlo, for the CMakeLists.tx is not really mandatory, it's just so the user can compile using CMake easily |
Aymane-ST
force-pushed
the
I3C
branch
2 times, most recently
from
fc4b44c to
282f2b0
Compare
cparata
left a comment
cparata
left a comment
There was a problem hiding this comment.
LGTM. Waiting for the official STM32duino Core release before integrating it.
Signed-off-by: Aymane Bahssain <aymane.bahssain@st.com>
| @@ -0,0 +1,55 @@ | |||
| #include "I3C.h" | |||
There was a problem hiding this comment.
I would rename all the I3C examples "LPS22DF_I3C_Basic.ino", "LPS22DF_I3C_DynAddrAssign.ino" and "LPS22DF_I3C_IBI.ino" putting them in the root of the "examples" folder and avoiding the inner folders. What about this proposal?
Signed-off-by: Aymane Bahssain <aymane.bahssain@st.com>
3 participants
Summary
This PR adds I3C support to
LPS22DFSensor.Main additions
I3CBus-based constructorI3CBusImplemented support
readRegBuffer(...)writeRegBuffer(...)Files added / updated
Notes
This PR depends on the I3C Library PR ref:stm32duino/Arduino_Core_STM32#2963